search

nurupo / ProjectTox-Qt-GUI

A cross-platform front end for ProjectTox Core library, written in C++11 with use of Qt5
GNU General Public License v3.0
342 stars 116 forks source link

File Transfer widget #68

Open nurupo opened 11 years ago

nurupo commented 11 years ago

Discussed in https://github.com/nurupo/ProjectTox-Qt-GUI/pull/60

It was decided (in the mentioned above issue) to make a separate widget for file transfer instead of using Message Display:

I mean, would users want the file transfer to be shown inside the message view instead of a separate widget for files?

I don't think so. Imagine you're chatting, sending a (larger) file and continue chatting. Than you have to scroll up to see if your download is done? No, I think a seperate file transfer widget is better for the usability.

The File Transfer widget is to be located between Friend Item Widget and Message Display widget. It should have two states: opened and closed. When opened, it should show a lists of files, including some QLineEdit to filter entries by filename. FireFox's download manager is a good example of what it should look like

jhjhj

When closed, it should display something like "File Transfer History" when there are no downloads

9b1d1cd4-2dda-11e3-8ace-618f6534efd1

or display general information about downloads in process (I probably overdid it a little)

d312218e-2dda-11e3-90bf-60d187c1b712

While each friend has their own File Transfer widget, it would be nice to have a global one in a new window, which merges information from all File Transfer widgets and can be called from the cogwheel menu. It may include more filtering/sorting options than friend's File Transfer widget does.

File Transfer widget should be written with support of loading/saving entries from a log db in mind, so that when adding support of logs it wouldn't be completely rewritten. Basically, have a convenient method to add a file entry with some state (already downloaded, paused, download date, etc) and a method to get entries with their states.

aitjcize commented 10 years ago

Honestly I like the idea of embedding the progress directly inside message view better, but you have a point. It would be a pain in the ass just having to scroll all the way up to the top to see the progress. I think I can probably made the modification to meet this design.

JamoBox commented 10 years ago

Perhaps from a design point of view, the file transfer progress could be displayed as a thin coloured bar travelling along the top of the "File Transfer History" bar that you have on that screenshot; much like loading progress bars found on YouTube at the top of the page and on many Android apps. the bar on your screenshot is too busy with the % complete and the up/down amount. That info would be much better off inside the widget itself rather than on the bar.