search

nurupo / ProjectTox-Qt-GUI

A cross-platform front end for ProjectTox Core library, written in C++11 with use of Qt5
GNU General Public License v3.0
341 stars 116 forks source link

Toggle username qlineedit focus when pressing change username button #8

Closed ilpianista closed 11 years ago

ilpianista commented 11 years ago

= subject

I had to clearFocus in onUsernameChange() too as QLineEdit::editingFinished() doesn't.

nurupo commented 11 years ago

Could you fix your second commit so that it uses introduced in Qt5 QRegularExpression? And for the regular expression, I would directly check whether the number is hex with ^([0-9A-F]+)$ and then check whether the string length is 64.

ilpianista commented 11 years ago

Ok done.

I didn't know 1 pull request show ALL commits :/ Do you want me to merge the two commits above (QRexExp with QRegularExpression)?

I also added CMakeLists files. Is this fine for you?

nurupo commented 11 years ago

Don't worry about the regexp commits, they are fine.

Not sure if we need the cmake. It would get outdated soon because I wouldn't update it since I won't use it, and if no one updates it, I would have to delete it.

ilpianista commented 11 years ago

If you don't mind to provide two build system, then I can maintain it.