Closed ryuuzaki42 closed 8 years ago
and doesn't worked because it was just for architecture x86 ( or libdir = /usr/lib/)
Sounds like it doesn't work because Slackware names directories differently than Debian does. The Makefile does work on both x86 and x86_64 Debian (and Ubuntu by extension), as there is no lib64
:
nurupo@debian:~$ uname -n
debian
nurupo@debian:~$ uname -m
x86_64
nurupo@debian:~$ ls /usr
bin include lib local sbin share src
So accepting your PR would break things for Debian users.
Oh, really? I was not aware about this, sorry. Thank you for answer me (and make me aware about this) : ). I will change for only the O.S. Slackware. I was thinking that all distros x86_64 has the folder lib64.
The Makefile looks good.
Could you remove screenshots from the PR? It's a good idea to have them, but if I add screenshots, I want more steps to be screenshoted than just 2 and things to be highlighted in them. I will make and add them on my own.
Ok, sure. It's better like you said, more screenshots and highlighted, but in any case make them, because it's little hard to find where we have check the box to enable the plugin. See you : ).
Could you squash these commits into one?
Done : )
Hello, I was trying your plugin in my laptop (running Slackware 14.1 X86_64, and doesn't worked because it was just for architecture x86 ( or libdir = /usr/lib/), so I decided to add x86_64, just two ifeq (and make a fork and a pull request, if you think it's good, accept);
Thank you for the awesome plugin! See you.
Commit: "Added support to architecture x86_64. Tested in one Slackware 14.1 Added two screenshots to make more easy to enable the plugin."