Closed liran-funaro closed 8 years ago
Thanks, I will look into it when I get time, which might take me a week or so.
Take a look at mouse-button-setting branch. I have
My plan is to merge this PR and follow it up with my commit from the mouse-button-setting branch, but before that I want to know if you have any input on my changes made in the mouse-button-setting branch.
Great. I was wondering how to make it update the settings immediately. It didn't work when the settings was under "interface". Please take a look at my commits at my fork under the new mouse-button-setting branch with its comments. I added some minor changes.
Ok, what do you think of mouse-button-setting now?
INDEX being the last lined up the closing parentheses nicer. Didn't notice that with your tabs. Maybe I should change it back.
Ok, moved the INDEX back to where you initially put it.
So, how do you want me to merge all of this?
?
Either way works for me. # 1 requires no effort on your part.
I pulled your mouse-button-setting branch into my master branch (option 2). You can merge it now.
Ok, cool.
I will add new Windows binaries within 24h, after I push the fix I mentioned in #5, add Docker instructions on how to build Windows binaries and maybe set up Travis-CI for this repo.
Thanks for the contribution :)
With pleasure
Defalt is middle click. I'm guessing that implementing it for older version will be similar but I can't test it.