Add optional mouse gestures (under interface settings). - Githubissues

nurupo / vlc-pause-click-plugin

Plugin for VLC that pauses/plays video on mouse click

GNU Lesser General Public License v2.1

914 stars 63 forks source link

Add optional mouse gestures (under interface settings). #13

Closed liran-funaro closed 8 years ago

liran-funaro commented 8 years ago

Defalt is middle click. I'm guessing that implementing it for older version will be similar but I can't test it.

nurupo commented 8 years ago

Thanks, I will look into it when I get time, which might take me a week or so.

nurupo commented 8 years ago

Take a look at mouse-button-setting branch. I have

refactored your changes
ported to 2.1.x (surprised it just worked, without any extra modifications required)
made it so the change in settings would take place immediately (without VLC restart)
and changed the default mouse button back to Mouse Left

My plan is to merge this PR and follow it up with my commit from the mouse-button-setting branch, but before that I want to know if you have any input on my changes made in the mouse-button-setting branch.

liran-funaro commented 8 years ago

Great. I was wondering how to make it update the settings immediately. It didn't work when the settings was under "interface". Please take a look at my commits at my fork under the new mouse-button-setting branch with its comments. I added some minor changes.

nurupo commented 8 years ago

Ok, what do you think of mouse-button-setting now?

nurupo commented 8 years ago

INDEX being the last lined up the closing parentheses nicer. Didn't notice that with your tabs. Maybe I should change it back.

nurupo commented 8 years ago

Ok, moved the INDEX back to where you initially put it.

nurupo commented 8 years ago

So, how do you want me to merge all of this?

Just close the PR and merge my mouse-button-setting branch into the master,
or you will pull my mouse-button-setting branch into your master branch (GitHub will pick it up and update the PR accordingly) and then I will merge the PR

?

Either way works for me. # 1 requires no effort on your part.

liran-funaro commented 8 years ago

I pulled your mouse-button-setting branch into my master branch (option 2). You can merge it now.

nurupo commented 8 years ago

Ok, cool.

I will add new Windows binaries within 24h, after I push the fix I mentioned in #5, add Docker instructions on how to build Windows binaries and maybe set up Travis-CI for this repo.

nurupo commented 8 years ago

Thanks for the contribution :)

liran-funaro commented 8 years ago

With pleasure