search

nurupo / vlc-pause-click-plugin

Plugin for VLC that pauses/plays video on mouse click
GNU Lesser General Public License v2.1
914 stars 63 forks source link

Only pause/play on left double-click if left button is selected #17

Closed ghost closed 7 years ago

ghost commented 8 years ago

If you select another button than left for pause/play action, playstate changes from play to pause (or the other way round) when toggling fullscreen via left double-click.

Added a check to only pause/play on left double-click if left button is selected.

nurupo commented 8 years ago

Thanks for reporting, I will check it in a week or so when I will have time, to make sure it's actually a bug and that this is a proper fix for it. This will be a bit time consuming, because I would need to make sure that it works as expected on Linux and Windows, as the mouse click behavior is not consistent across different operating systems. I don't remember what the exact difference in the behavior is, but an example would be: on one system if you do a double click, you would get a the mouse() callback called twice, for single and double click events, on another you would get it called only once, for only double click.

ghost commented 8 years ago

Because of the added p_mouse_new->b_double-click in c806f3ccad73cd4ea4b799c90d27cf422f0a4310 pause/play is always triggered on left double-clicks. I think that's not wanted if you select the middle button for example. I've tested it on Windows and Linux with vlc-2.2.3.

nurupo commented 7 years ago

My "I will check it in a week or so" suddenly became "I will check in a year or so", huh. I still don't have time for this right now, but I'm letting you know that I have not forgotten about this pull request.

nurupo commented 7 years ago

Ok, got it tested on Debian Jessie with VLC 2.2.4 and on Windows 7 with 32-bit VLC 2.1.5 and 2.2.4 -- works as expected for me.

nurupo commented 7 years ago

Thanks for the contribution and sorry for the wait.