search

nurupo / vlc-pause-click-plugin

Plugin for VLC that pauses/plays video on mouse click
GNU Lesser General Public License v2.1
933 stars 63 forks source link

Does not work with 64bit 3.0.x nightlies #3

Closed adem0x closed 9 years ago

adem0x commented 9 years ago

I have vlc-3.0.x-64bit-win.zip and tried it with the plugin. After carefully applying all the settings, and restarting VLC, this is what happens:

VLC does start, but the moment I try to play any movie with it, VLC goes away quietly.

BTW, I did try older versions too, but the current version of VLC 64 I am using says this in Help | About: 3.0.0-git-20150306-0402 Vetinari

nurupo commented 9 years ago

Failed to reproduce, everything works fine for me.

Steps taken:

  1. Download VLC 3.0.0-git-20150306-0402.zip
  2. Extract it
  3. Download vlc-3.0.x-64bit-win.zip
  4. Copy libpause_click_plugin.dll from the downloaded vlc-3.0.x-64bit-win.zip to vlc-3.0.0-git-20150306-0402/plugins/video_filter/
  5. Run vlc-3.0.0-git-20150306-0402/vlc.exe
  6. Go to the advanced preferences Tools -> Preferences -> Show settings -> All
  7. Enable Video -> Filters -> Pause/Play video on mouse click
  8. Enable Interface -> Control Interfaces -> Pause/Play video on mouse click
  9. Save the preferences
  10. Restart VLC
  11. Get a sample video file to play. (Taken from https://support.apple.com/en-us/HT201549). Caution: the video is a bit too loud.
  12. Unzip the .mp4 file
  13. Drag'n'drop it into the running VLC
  14. Try clicking on the screen while the video plays
  15. Observer video getting paused on the first click and resumed on the second

Try reproducing my steps and say if it works. Then describe steps to reproduce the behavior you get.

adem0x commented 9 years ago

I have done everything you've said to the letter --except that I have placed the dll in a subfolder called 'plugins\libpause_click' which is what VLC does for all other plugins.

From the onclosed snapshots, you can see that the settings are as you've instructed.

And, the result is the same: On starting to play sample_mpeg4.mp4, VLC simply crashes.

Starting the VLC next time, I get the usual 'VLC Crash Reporting' dialog which becomes an endless cycle. vlc_about vlc_interfaces vlc_filters vlc_pause_click

nurupo commented 9 years ago

Strange, still can't reproduce it here. But at least now I'm sure you are doing everything right.

Can't really find out why it crashes without being able to reproduce it though. Maybe some other option you have set is conflicting with the plugin.

You could try getting the debug version of VLC, then extracting this archive with debugger into VLC's root directory. Then set up the pause_click plugin and when it's ready run the debug-print-bt-on-crash.bat script. It's configured to run VLC in such a way that whenever VLC crashed (or just terminates) it opens a text file in a notepad, which contains some debug info. Try playing the sample_mpeg4.mp4 file and then paste the debug info to http://pastebin.com/ and post a link on here. It might shed a light on why it's crashing/disappearing.

It's the most I can do about it without being able to reproduce.

adem0x commented 9 years ago

I am sorry for the blunder above --didn't mean to close the issue.

Tried posting the log here but didn't workout best.

Here is the pastebin link: http://pastebin.com/wnQABL1v

nurupo commented 9 years ago

Does it crash without my plugin?

nurupo commented 9 years ago

It sounds like it's a problem with libdirect3d_plugin. Try using other video output. You can set it in Preferences -> (simple) -> Video -> Output.

SeanMcG commented 9 years ago

I can't reproduce this, with or without the plugin. I used vlc-3.0.0-git-20150308-0402-win64-debug from the nightlies and followed nurupo's steps above on a Microsoft Surface 2 Pro running Win8.1.

adem0x commented 9 years ago

I first completely uninstalled VLC and made sure that there was no residue of it in the system (using 'Registry First Aid' which is excellent for this purpose, IME).

Then ran 'sfc /scannow' to make sure there was no systemic problem.

Then downloaded these files:

http://nightlies.videolan.org/build/win64/vlc-3.0.0-20150308-0402/vlc-3.0.0-git-20150308-0402-win64.7z

https://github.com/nurupo/vlc-pause-click-plugin/releases/download/0.2.0/vlc-3.0.x-64bit-win.zip

Installed VLC in under 'C:\ProgramData\VLC\' to avoid any Windows protection problem that might have arisen if installed it under 'C:\Program Files\VLC\'

Before installing the 'vlc-pause-click-plugin', I made sure that the freshly installed VLC plays 'sample_mpeg4.mp4' as it should.

It did.

Then, I created a folder called 'C:\ProgramData\VLC\plugins\pause_click' where I copied the contents of 'vlc-3.0.x-64bit-win.zip' [i.e. libpause_click_plugin.dll].

NOTICE that I did not copy the 'libpause_click_plugin.dll' directly under 'VLC\plugins\' but to its own folder, i.e. 'VLC\plugins\pause_click\'

Then in VLC's settings, I made the necessary adjustments (see images above); and..

IT WORKS! :)

I have no idea why it didn't work before: Probably because of some obscure setting that might have remained from an earlier version; or something like it.

Anyway, I can now happily confirm that it DOES WORK. :)

Thank you for your help and efforts.

[I'll leave it to you to close this thread.]

nurupo commented 9 years ago

made sure that there was no residue of it in the system (using 'Registry First Aid' which is excellent for this purpose, IME).

I thought VLC stored config files somewhere on the file system, not in registry (let's pretend registry is not stored on fs).

Well, good thing it got fixed. Next time someone has a similar issues -- I will just point them here.