search

nurupo / vlc-pause-click-plugin

Plugin for VLC that pauses/plays video on mouse click
GNU Lesser General Public License v2.1
945 stars 64 forks source link

Doesn't work on VLC 3.0 & macOS #34

Closed jaromiru closed 6 years ago

jaromiru commented 6 years ago

I followed the steps, copied the library into plugins directory and ran vlc with the --reset-plugins-cache argument, after which it finally showed up. I checked the plugin both under interfaces and video filters, however, it doesn't work. When I click on the screen, the video doesn't pause/resume.

nurupo commented 6 years ago

Huh, that's weird. If you are able to get the plugin to show up in the Preferences and check both checkboxes then it should be working. I can add some print statements into the code to see what is working and what is not, that might help to identify the issue.

nurupo commented 6 years ago

Alright, here is the plugin build based on the debug branch where I have added some print statements.

vlc-3.0-macosx (2).zip

I want you to:

  1. Install this plugin
  2. Start vlc from the terminal
  3. Drag&drop a video file into VLC
  4. Play it
  5. Click on the video image exactly once
  6. Wait around 5 seconds
  7. Click on it again
  8. Close VLC
  9. Copy-paste the output you got in the terminal in here

Here is what I'm getting on Linux, with the double-click ignoring plugin option disabled:

$ vlc
VLC media player 3.0.0 Vetinari (revision 3.0.0-30-gef4c265336)
[00005623d9db2a30] main libvlc error: stale plugins cache: modified /usr/lib/x86_64-linux-gnu/vlc/plugins/video_filter/libpause_click_plugin.so
[00005623d9e8d760] pause_click interface: OpenInterface
[00005623d9db2a30] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
[00005623d9db1350] main playlist: playlist is empty
[00007f8fd0c6ee80] pause_click filter: OpenFilter 1
[00007f8fd0c6ee80] pause_click filter: OpenFilter 3 success
[00007f8fd0c6ee80] pause_click filter: CloseFilter timer_initialized: 1
[00007f8fd0c6ee80] pause_click filter: OpenFilter 1
[00007f8fd0c6ee80] pause_click filter: OpenFilter 3 success
[00007f8fd0c6ee80] pause_click filter: mouse 1
[00007f8fd0c6ee80] pause_click filter: mouse 3 mouse_button_value: A
[00007f8fd0c6ee80] pause_click filter: mouse 4 mouse_button: 0
[00007f8fd0c6ee80] pause_click filter: mouse 5: 1
[00007f8fd0c6ee80] pause_click filter: mouse 6: 0, 1, 0
[00007f8fd0c6ee80] pause_click filter: mouse 7: 0
[00007f8fd0c6ee80] pause_click filter: mouse 8: 1
[00007f8fd0c6ee80] pause_click filter: mouse 12
[00007f8fd0c6ee80] pause_click filter: pause_play 1: 0x5623d9e8d760
[00007f8fd0c6ee80] pause_click filter: pause_play 3: 0x5623d9db1350, 1
[00007f8fd0c6ee80] pause_click filter: mouse 13
[00007f8fd0c6ee80] pause_click filter: mouse 1
[00007f8fd0c6ee80] pause_click filter: mouse 3 mouse_button_value: A
[00007f8fd0c6ee80] pause_click filter: mouse 4 mouse_button: 0
[00007f8fd0c6ee80] pause_click filter: mouse 5: 1
[00007f8fd0c6ee80] pause_click filter: mouse 6: 0, 1, 0
[00007f8fd0c6ee80] pause_click filter: mouse 7: 0
[00007f8fd0c6ee80] pause_click filter: mouse 8: 1
[00007f8fd0c6ee80] pause_click filter: mouse 12
[00007f8fd0c6ee80] pause_click filter: pause_play 1: 0x5623d9e8d760
[00007f8fd0c6ee80] pause_click filter: pause_play 3: 0x5623d9db1350, 2
[00007f8fd0c6ee80] pause_click filter: mouse 13
[00007f8fd0c6ee80] pause_click filter: CloseFilter timer_initialized: 1
[00005623d9e8d760] pause_click interface: CloseInterface
QObject::~QObject: Timers cannot be stopped from another thread
jaromiru commented 6 years ago

There you go:

$ /Applications/VLC.app/Contents/MacOS/VLC --reset-plugins-cache
VLC media player 3.0.0 Vetinari (revision 3.0.0-3-g7821ebf808)
[00007f8425e35510] pause_click interface: OpenInterface
[00007f8425c23a30] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
[00007f8425d23110] main playlist: playlist is empty
[00007f8425e35510] pause_click interface: CloseInterface
nurupo commented 6 years ago

Looks like the video filter part of the plugin is disabled. Are you sure you have this checkbox enabled?

jaromiru commented 6 years ago

Absolutely positive that it's on.

nurupo commented 6 years ago

I'm out of ideas then. The video filter part of the plugin never gets called by VLC, and as far as I know, that's only possible if the checkbox is not checked or if there is something wrong in the module declaration, but another person in https://github.com/nurupo/vlc-pause-click-plugin/issues/32 got the plugin running on macOS with VLC 3.0 just fine and you say that the checkbox is checked, so it can't be either of those. There is probably something that I don't know going on here. As a desperate last attempt, I can suggest trying to remove all the files VLC creates (e.g. on Linux it creates ~/.config/vlc directory with vlc-qt-interface.conf and vlcrcand files, as well as ~/.cache/vlc directory), then uninstall VLC, install it anew and try adding and using the plugin again.

jaromiru commented 6 years ago

Ok, I followed https://wiki.videolan.org/VSG:ResetPrefs/#Mac_OS_X, removed the app completely, reinstalled it and now it works. Interesting.