search

nurupo / vlc-pause-click-plugin

Plugin for VLC that pauses/plays video on mouse click
GNU Lesser General Public License v2.1
914 stars 63 forks source link

Right click Menu #55

Closed gkrahmer closed 5 years ago

gkrahmer commented 5 years ago

I just added this plugin to my VLC, only problem is I like having the Right Click as my "play/pause" and while it does work, the menu that is displayed by default with the right click still opens. Is there a way of disabling said menu?

Thanks!

nurupo commented 5 years ago

That's interesting, never expected anyone to actually use the Right Button option. I have added those button choices just because I could and having an option to use Middle Button sounded nice.

Anyway, I can modify the plugin to prevent the context menu from appearing. I wouldn't be able to properly test it for about a week though, don't have a Windows machine nearby, so releasing this change will have to wait. Meanwhile you can test it yourself. I have pushed the code to suppress-context-menu branch in case you compile from source, and here are Windows binaries:

By the way, if you are using Right Button instead of Left Button because you don't like the video pausing and then playing when you double-click to full screen - there is an option called "Ignore double clicks" which, when enabled, will make is so that plugin doesn't react to double clicks, it won't pause/play the video on a double click, the video will remain in its current state (paused/playing).

nurupo commented 5 years ago

Say if this works for you and what OS and VLC version you use.

gkrahmer commented 5 years ago

That's interesting, never expected anyone to actually use the Right Button option. I have added those button choices just because I could and having an option to use Middle Button sounded nice.

Anyway, I can modify the plugin to prevent the context menu from appearing. I wouldn't be able to properly test it for about a week though, don't have a Windows machine nearby, so releasing this change will have to wait. Meanwhile you can test it yourself. I have pushed the code to suppress-context-menu branch in case you compile from source, and here are Windows binaries:

By the way, if you are using Right Button instead of Left Button because you don't like the video pausing and then playing when you double-click to full screen - there is an option called "Ignore double clicks" which, when enabled, will make is so that plugin doesn't react to double clicks, it won't pause/play the video on a double click, the video will remain in its current state (paused/playing).

I got used to pausing the video with the right click from using MPV, I guess it must be weird for some.

So far it's working flawlessly, thank you very much!

OS: Windows 10 64bit VLC: 3.0.6

nurupo commented 5 years ago

Here are pre-release binaries based on the current master branch, if you want to test them. The right click context menu stuff is no longer hard-coded, there are options for it now. You can also re-assign the context menu popup and fullscreen toggle to any mouse button now.

All that's left for the release is make updated Windows VLC screenshots for the README file and create a version tag.

Screenshot

vlc-2.1-32bit-win.zip vlc-2.1-64bit-win.zip vlc-2.2-32bit-win.zip vlc-2.2-64bit-win.zip vlc-3.0-32bit-win.zip vlc-3.0-64bit-win.zip

nurupo commented 5 years ago

Should be addressed by the 2.0.0 release https://github.com/nurupo/vlc-pause-click-plugin/releases/tag/2.0.0