Release 2.2.0 seems to have only partial support for `LIBVLC_MAJOR_VERSION >= 4`

[kvaradhan3]

With release 2.2.0, for instance, I see compile errors such as:

cc -std=gnu11 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-pro
tection -fPIC -I/usr/include/vlc/plugins -D__PLUGIN__ -D_FILE_OFFSET_BITS=64  -DPIC -I. -Isrc -DMODULE_STRING=\"pause_click\"  -c -o pause_click.o pause_click.c
pause_click.c: In function ‘vlc_entry’:
pause_click.c:125:5: warning: implicit declaration of function ‘set_category’; did you mean ‘set_subcategory’? [-Wimplicit-function-declaration]
  125 |     set_category(CAT_VIDEO)
      |     ^~~~~~~~~~~~
      |     set_subcategory
pause_click.c:125:28: error: expected ‘;’ before ‘vlc_set’
  125 |     set_category(CAT_VIDEO)
      |                            ^
      |                            ;
pause_click.c:132:92: error: macro "add_integer" passed 5 arguments, but takes just 4
  132 |                 "Note that the scroll buttons might not work, that's a bug in VLC."), false)
      |                                                                                            ^

Which appear to be addressed in the mainline.

Is this expected?

[nurupo]

Right, that's to be expected. Try using the master branch -- that should work with the recent VLC 4.

The 2.2.0 plugin release did in fact work with VLC 4, but that was at the time of the plugin release, in 2020. VLC 4 has changed its API since then and thus the 2.2.0 plugin no longer works with it. I have only recently updated the plugin with the up-to-date VLC 4 support a413f87777b106345ac22599db0a7dfe59dcfabc, which hasn't made into a release yet. (There are a few more changes I want to make before making a release.)