nus-apr / CrashRepair

Security Vulnerability Repair via Concolic Execution and Code Mutations
11 stars 1 forks source link

libtiff/REDTEAM-CVE-2017-17095 and REDTEAM-CVE-2018-18557: Unable to generate crash free constraint #168

Open ChrisTimperley opened 1 year ago

ChrisTimperley commented 1 year ago

REDTEAM-CVE-2018-18557:

                [warning] Unknown Crash Reason: jbg_dec_init

                [error] unknown crash type: None
        Analysis Failed
        Unable to generate crash free constraint
        Runtime Error
        Error. Exiting...

REDTEAM-CVE-2017-17095:

                [warning] Unknown Crash Reason: jpeg_std_error

                [error] unknown crash type: None
        Analysis Failed
        Unable to generate crash free constraint
        Runtime Error
        Error. Exiting...
rshariffdeen commented 1 year ago

CVE-2018-18557 fixed in 89b9217

rshariffdeen commented 1 year ago

fixed the reported issue of CVE-2017-17095 in 49c17d4

ChrisTimperley commented 1 year ago

@rshariffdeen CVE-2017-17095 still fails on the latest commit:

                extracting instruction trace
                        [note] program did not crash
                        [note]: the program did not crash

Run time statistics:
-----------------------

        Startup: 0.000 minutes
        Build: 0 minutes
        Concrete Analysis: 0 minutes
        Concolic Analysis: 0 minutes
        Total Analysis: 0 minutes
        Localization: 0 minutes

CRepair finished successfully after 11.008 minutes 

FATAL ERROR: analysis failed: no localization file was produced
root@83fdcfeaa13d:/data/vulnloc/libtiff/REDTEAM-CVE-2017-17095# 
rshariffdeen commented 1 year ago

The reported issue is fixed for REDTEAM-CVE-2017-17095 which was missing link to libjpeg library, this is fixed. However, the exploit trace includes the use of longjmp which is not supported by KLEE hence this bug cannot be reproduced using Klee.

ChrisTimperley commented 1 year ago

Any updates on REDTEAM-CVE-2018-18557?

rshariffdeen commented 1 year ago

It was already fixed in 89b9217 I updated the analysis to generate fix constraints with call expressions, in ae2eb5d however the linter is not parsing it, you will have to update the parser?