nus-cs2030 / 2021-s1

28 stars 48 forks source link

Edit of PE code #149

Open rickyaandrew opened 3 years ago

rickyaandrew commented 3 years ago

hi i am abit unclear as of how the PE is graded. i understand that we are only allowed to do minimal changes, but if i have a code, and i would like to move this exact code from one class to the other class then remove the current class, will it be counted as huge changes or it count as small changes? Basically i would like to remove this class and move all the function to another class (i did not implement any new function), will i get penalised alot? or i would like to remove redundant functions in my classes, will i get penalised?

crys-22 commented 3 years ago

im not very sure but i think removing a whole class would be a big change... might be better if you can think of other ways to implement the code without moving the code from one place to another... later they count it as one edit for removing the class + another edit for adding the same chunk into another class?? also i think no need to remove redundant functions later they count it as edits also HAHAH i think keeping it there is better cos won't get penalized if never use(?)

limyingying2000 commented 3 years ago

If I have more lines for the importing of the java package, will it be counted as edit as well?

benluiwj commented 3 years ago

I think its more of how many methods you add and how much change was made to your original code. But if something is unavoidable then I think it shouldn't get marked down as much?