nus-cs2103-AY1718S1 / forum

Discussion Forum
5 stars 0 forks source link

Sort functionality for AddressBook #117

Open karrui opened 7 years ago

karrui commented 7 years ago

This is how I implemented sort (and I guess how many would have implemented), but here it is.

My details and implementation can be found here.

Relevant PRs: Main commit: https://github.com/CS2103AUG2017-F11-B3/main/commit/f1a795ab72b304ab84085455ccaff284c7e40a2f

sort now saves the ordering: https://github.com/CS2103AUG2017-F11-B3/main/commit/02961f37abc3029951316155a74f7ede9ff8ae60

Please do give some suggestions on how I can improve it too, as there are some questionable implementation in it such as the parsing of the parameters to return a true or false for the sort order, but I cannot really think of a cleaner way to do so.