search

nus-cs2103-AY1718S1 / forum

Discussion Forum
5 stars 0 forks source link

Music Player to play music at the background - Edited to Beep sound for incorrect Command. #123

Open justintkj opened 6 years ago

justintkj commented 6 years ago

This feature allows music of your choosing to be played at the background whenever the app is open. nextsong command allows you to change the current song playing! This utilizes the javafx.media import to start the playlist and play the song You can find my PR here! https://github.com/CS2103AUG2017-F09-B3/main/pull/10/files As can be seen, currently, i only have two songs in , "fur elise" and "kiss the rain". Users can navigate the playlist using the nextSong() method.

I am planning to add a stop music feature in this app and a playback function to keep the musics playing after it reaches the last song.

Edited the features to play a beep sound when an incorrect command is entered instead of music played. The updated commit can be found here : https://github.com/CS2103AUG2017-F09-B3/main/pull/68/commits/dffdea8d8b2f117cebf7c285bad79bd7b0c200cc Currently, the 'Sound' will be triggeered whenever a parseException / Command Exception is called.

Feel free to contact me for any queries in using this import, or if you have any comments that can help me improve!

AceCentury commented 6 years ago

Just curious, isn't this deviating a bit too far from the point of an Address Book? Wouldn't it be better for users to use a dedicated music player instead, with more refined features such as library management, audio equaliser etc?

justintkj commented 6 years ago

Hi AceCentury,

It was just an idea generated from our userGuide. It's not a hassle to implement and it allows the user to have a background music playing. If the user does not like the function, the music can definitely be stopped anytime! If it's anything worthy to note, i strongly believe that an addressbook shouldn't be confined to the visual realm only. However, it is also notable that a music function has a low priority in the functionality, hence it's only given a one star priority in our userGuide. Thanks for the comment anyway! :)

AceCentury commented 6 years ago

Thanks for sharing your thoughts about this feature. Just wondering, have you measured resource usage of the app with and without the music player? I'm curious to see if it will have much of an impact.

Also, some areas to consider for improvement:

  1. Previous song command
  2. Shuffle songs command
damithc commented 6 years ago

@justintkj there are some marks allocated to 'how well the features fit together'; this feature is going to need a strong justification when evaluated under that aspect. If not, the whole team lose marks (because maintaining product integrity is a team responsibility). A music player feature can fit an app that is used for a long period and also prevents other music players from running in the background. In all other cases, people will prefer to use an independent music player app. As you can see, very few applications fit that bill, and that's why you don't see such a feature in most software apps. An 'addressbook for music lovers' doesn't sound like a good combination unless there is some functionality that combines music with contacts.

justintkj commented 6 years ago

Thanks prof and ace century for the feedbacks,

I have decided to revamp the feature of music player to play sounds when incorrect commands are entered. This way, it sounds more useful as an addressbook app.