search

nus-cs2103-AY1718S1 / forum

Discussion Forum
5 stars 0 forks source link

Map function to map Person's address on Google Maps #124

Open liliwei25 opened 6 years ago

liliwei25 commented 6 years ago

This is my PR on how to implement a Map command as well as a Event handler to handle the Map command in order to display the specified Person's address on Google Maps in a browser.

RonakLakhotia commented 6 years ago

Hi, I also implemented a similar feature recently which involved FaceBook integration. Just wanted to suggest, would it be better to include a test to check if the expectedUrl to be loaded and the url of the location generated by the browser panel are the same? Similar to the display() test in the BrowserPanelTest class.