nus-cs2103-AY1718S1 / forum

Discussion Forum
5 stars 0 forks source link

Setup Coveralls #200

Closed erik0704 closed 6 years ago

erik0704 commented 6 years ago

I have trouble setup coveralls page. Some groups said that they just have to setup travis and the coveralls overage badge will work.

I got travis to work however my coveralls page instead of

screen shot 11-09-17 at 02 12 pm

It just show me the setup page instead which was quite non-descriptive. screen shot 11-09-17 at 02 15 pm

raisa2010 commented 6 years ago

Hi there! Have you signed in with your GitHub account and added your repos to the list?

erik0704 commented 6 years ago

screen shot 11-09-17 at 03 29 pm

Yes I have done so. It shows no build though.

screen shot 11-09-17 at 03 32 pm

karrui commented 6 years ago

Have you tried creating a PR/ committing to that branch? Coveralls is not retroactive, it must detect a new commit to the branch.

erik0704 commented 6 years ago

Yes. However the travis build is currently failing. Does coveralls only detect passing build ?

karrui commented 6 years ago

Yes, only passing builds will be processed

Regards, Karrui


From: erik0704 notifications@github.com Sent: Thursday, November 9, 2017 3:47:44 PM To: nus-cs2103-AY1718S1/forum Cc: Kar Rui Lau; Comment Subject: Re: [nus-cs2103-AY1718S1/forum] Setup Coveralls (#200)

Yes. However the travis build is currently failing. Does coveralls only detect passing build ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/nus-cs2103-AY1718S1/forum/issues/200#issuecomment-343073271, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVG5EGgHLJlm3RRHa1mJp42bYuy7X_diks5s0q4fgaJpZM4QXfrk.

yunpengn commented 6 years ago

The webhook used to trigger Coveralls from Travis CI is almost the last step in a Travis CI build.

Thus, if any test is still failing, the build already terminates before Coveralls in trigged.

damithc commented 6 years ago

@erik0704 did it work?

erik0704 commented 6 years ago

Yes I got it to work after fixing travis checkstyle problems. Thanks everyone for the help.