search

nus-cs2103-AY1718S1 / forum

Discussion Forum
5 stars 0 forks source link

Issue about building travis #203

Closed Adoby7 closed 6 years ago

Adoby7 commented 6 years ago

Does anyone know why this problem happens during building travis (see the red command below). It seems that there are some problems in "before cache" https://travis-ci.org/CS2103AUG2017-W14-B4/main/builds/299958610?utm_source=github_status&utm_medium=notification screenshot 2

damithc commented 6 years ago

Post link to the relevant PR?

Adoby7 commented 6 years ago

@damithc I think this problem exists for a long time, and is hard to retrieve which feature causes it, I am trying to find it

Adoby7 commented 6 years ago

@damithc I think this PR causes the problem firstly https://github.com/CS2103AUG2017-W14-B4/main/pull/95

tshradheya commented 6 years ago

I just saw your team repo, and looks like you guys have been merging failed builds for a pretty long time( 20+ failed PR's )

You should have made your master branch protected to avoid this. Now it is quite tough to figure out if the PR change had the problem or was it because the master itself was not correctly built.

You could start off by resolving these error's image

Even if your PR has no problems, since Travis builds PR's merging them to master, you will still find the build failing.

Adoby7 commented 6 years ago

@tshradheya good news is that every thing works well after resolving these 2 errors. Thank you very much!

damithc commented 6 years ago

Thanks @tshradheya for saving the day 💯