search

nus-cs2103-AY1718S1 / forum

Discussion Forum
5 stars 0 forks source link

Test Failure #213

Closed huiyiiih closed 6 years ago

huiyiiih commented 6 years ago

Hello guys,

I keep failing 3 test cases:

  1. XmlAddressBookStorageTest > readAndSaveAddressBook_allInOrder_success
  2. StorageManagerTest > addressBookReadSave
  3. AddressBookTest > resetData_withValidReadOnlyAddressBook_replacesData

I can't seem to find out why the errors occur. I checked the comparison failure and there is an extra space for the expected. But I can't seem to find out why the extra space occurs.

screen shot 2017-11-11 at 23 23 07
damithc commented 6 years ago

Provide the link to PR?

huiyiiih commented 6 years ago

https://github.com/CS2103AUG2017-T14-B3/main/pull/103

@damithc

damithc commented 6 years ago

Looks like there are some checkstyle errors. You may want to fix them first so that the travis log shows which tests are failing.

huiyiiih commented 6 years ago

I have fixed the checkstyle errors. @damithc

damithc commented 6 years ago

I assume these tests are failing locally as well. One thing you can do is to start a new branch and introduce your changes tiny bit at a time to see which change causes the test failure.

huiyiiih commented 6 years ago

I found out the causes, but I am not sure why they would cause failure to the 3 class I mentioned earlier.

damithc commented 6 years ago

If you can isolate the minimal code that causes the test failure, you can create a PR with just that code so that others can take a look at it to see if they can spot the cause.

huiyiiih commented 6 years ago

I can state where the code that caused it.

screen shot 2017-11-12 at 14 45 47

The code that caused the error is when I added withRelation("Benson Meier [siblings]") and withRelation("Alice Pauline [siblings]") to the 2 different persons.