taojiashu
commented
6 years ago The experimental PR in my team repo didn't go through Travis. But in my own repo, it failed in Travis. The errors are exactly the same as the 3 error above.
Closed taojiashu closed 6 years ago
taojiashu
commented
6 years ago The experimental PR in my team repo didn't go through Travis. But in my own repo, it failed in Travis. The errors are exactly the same as the 3 error above.
damithc
commented
6 years ago Are the failures related to browser panel content?
taojiashu
commented
6 years ago Yes I updated the facebook feature. However, the test is about google search, so it should not be affected. I added Google Maps feature last week and there was no problem. And my experimental branch did not do anything to the code, and it failed too. I am afraid that my team's master branch will fail in Travis if I rebuild now.
damithc
commented
6 years ago It's probably because Google is rejecting search requests due to our builds on Travis servers issuing too many search requests. Try removing the check for the content of the browser panel. It will weaken the test but will allow the test to pass.
taojiashu
commented
6 years ago Ok! Thanks Prof!
Adoby7
commented
6 years ago @taojiashu Just disable all tests related to Web, using @ignore or commenting them, see this link https://nus-cs2103.slack.com/messages/C6JMW6SSZ/convo/C6JMW6SSZ-1508476015.000144/?thread_ts=1508476015.000144
taojiashu
commented
6 years ago @Adoby7 Thank you for your suggestion. I have commented out all the relevant assertions and it can pass now.
I keep encountering the same three errors in Travis today. But all tests can pass locally in IntelliJ. I suspect it is a Travis issue, so I did an experiment. I pulled from my team's master branch, which passed Travis yesterday afternoon. Then I made a new branch and added a new line of comment to it. And this caused Travis to fail again. These are the three errors I am encountering right now.
This is the link to my PR and experimental PR.
Do I have to disable them?