search

nus-cs2103-AY1920S1 / forum

Forum
1 stars 1 forks source link

UIPartTest fail #133

Closed Ellieyee closed 5 years ago

Ellieyee commented 5 years ago

Environment

main forked from addressbook3, runs on java11

Issue

After adding new UI increments my tests for UiPartTest seem to fail. Specifically the constructor_missingFileUrl_throwsAssertionError() and constructor_invalidFileUrl_throwsAssertionError(). However, I have not modified the existing UIPart neither have I created any new UIPart within this iteration. (previous iterations have all passed). Moreover, gradlew test shows Build Successful as well as my build report), whereas travis shows a build failed during the PR. https://travis-ci.org/AY1920S1-CS2103-T14-2/main

Code/Log Trace

My changes can be viewed here: https://github.com/AY1920S1-CS2103-T14-2/main/pull/61/files

shaoyi1997 commented 5 years ago

Hmmm, based on the Travis job log it seems like the build failure is not due to constructor_missingFileUrl_throwsAssertionError() and constructor_invalidFileUrl_throwsAssertionError() tests failures.

Rather, it's due to an AssertionFailedError in your TutorialTest, as seen below.

image

damithc commented 5 years ago

@Ellieyee is the issue resolved?

Ellieyee commented 5 years ago

yes! Thanks @shaoyi1997 :)