search

nus-cs2103-AY1920S1 / forum

Forum
1 stars 1 forks source link

Closing issues from the PE-D/PE #161

Closed Parcly-Taxel closed 4 years ago

Parcly-Taxel commented 5 years ago

Can we close (but obviously not delete, since both repositories will be checked in the tutor grading) the bugs we created in the dedicated repositories for the practical exam dry run and (in two weeks' time) the practical exam itself?

damithc commented 5 years ago

No. Closed bug reports are considered as bug reports withdrawn by the tester e.g., created by mistake in the first place. Our grading scripts will only consider open issues in PED and PE repos.

Parcly-Taxel commented 5 years ago

@damithc In any case, when can we mark them as closed?

damithc commented 5 years ago

@Parcly-Taxel Grading work continues until Dec 9th. You can close the issues after that.

Parcly-Taxel commented 5 years ago

I heard that some things I wanted to do could not be done until 2020, what are they?

damithc commented 5 years ago

A easy to remember guideline is not to touch the issues in PE or PED repos until you receive your grade. After that, you can delete the PE and PED repos if you wish.

whneo97 commented 5 years ago

Hi prof @damithc , sorry just to double-check, will the following then be correct?

damithc commented 5 years ago
  • We are not to close the issues we posted until Dec 9th (unless we intend to withdraw them.
  • For the PED issues posted on our team repo, we may close the issue by the bot as soon as we have resolved the problems described (?). However, we are not to close the corresponding issues opened by the original author. (?)
  • For PE issues, we are not to rectify or close the issues at all, be it by the bot or by the original author. (?)

Yes, that's correct. You are free to do anything with the PED issues posted on your team repo. We do not take them for grading.

whneo97 commented 5 years ago
  • We are not to close the issues we posted until Dec 9th (unless we intend to withdraw them.
  • For the PED issues posted on our team repo, we may close the issue by the bot as soon as we have resolved the problems described (?). However, we are not to close the corresponding issues opened by the original author. (?)
  • For PE issues, we are not to rectify or close the issues at all, be it by the bot or by the original author. (?)

Yes, that's correct. You are free to do anything with the PED issues posted on your team repo. We do not take them for grading.

Okay noted, thank you prof for the clarification!