nus-cs2103-AY1920S1 / forum

Forum
1 stars 1 forks source link

Travis build fails due to coveralls/asciidoctor #167

Closed huiminlim closed 4 years ago

huiminlim commented 5 years ago

Please read up on how to write a good question

Environment

Describe your development environment

Issue

I carried on my coding activities as per normal and I created a pull request to submit to my team repo. However, travis keeps failing my PR and codes even though the travis for my own repo passes and says that build is successful.

This is the screenshot of Travis (failed) build from my team repo: image This is the link: https://travis-ci.org/AY1920S1-CS2103-F09-2/main/builds/608332992?utm_medium=notification&utm_source=github_status Build number is #556

This is the screenshot of my own repo's Travis image

https://travis-ci.org/huiminlim/main/builds/608332966?utm_medium=notification&utm_source=github_status

damithc commented 4 years ago

@huiminlim what happens when you run the gradle task locally? Run that task only. Try to do that on Windows as well as Mac.

huiminlim commented 4 years ago

Hi Prof Damith, looks like this is the output i obtained on Windows 10, and no error is shown when I run both the gradle and just the task alone. Not sure if I did the correct way as you advised.

image

huiminlim commented 4 years ago

We executed the same command on a mac

This is the complete task image

This is the asciidoctor only task

image

geshuming commented 4 years ago

You can try triggering a custom build on travis, and run ./gradlew asciidoctor --info to see what could be causing the issue?

geshuming commented 4 years ago

Under "more options", click on the "Trigger build" option and insert a custom yaml config to

image

damithc commented 4 years ago

@huiminlim looks like your master branch itself is failing. Perhaps you can remove asciidoctor task from the travis and get everything else to pass first? After that, open a new PR that adds back the asciidoctor task and try to fix the problem in that PR.

tuandingwei commented 4 years ago

Try checking your test cases. It could be that you might have failed one of the test cases.

groot0x12 commented 4 years ago

@tuandingwei the cause of the error wasn't the test cases. I believe it was from either ASCIIDoctor or Coveralls as there is some dependency within the CI there. We tried commenting out asciidoctor or coveralls but both resulted in further errors because asciidoctor relies on coveralls do generate a html file that is required. we've gotten it to pass temporarily by commenting out our deploy segment within our gradle file but that affects our publication

damithc commented 4 years ago

One possibility is to run the asciidoctor task locally and push the generated html files to the gh-pages branch of the repo to simulate how Travis depoly the generated website.

huiminlim commented 4 years ago

Thanks Prof, that works.