nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Fines not updated progressively while LiBerry is open #1152

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

While LiBerry is open, it appears that it does not update the Fines for the user when the date is past the borrowing due date. This can cause issues especially if LiBerry is used in libraries where systems are always on and LiBerry is constantly active.

Screenshot 2019-11-23 at 4.53.04 PM.png (Note the system date and the Fines amount.)

A workaround is if libararians are required to restart LiBerry everyday, but that would present a inconvenience towards to users and cause issues regardless in the case of non-adherance.

To replicate:

  1. Type serve id/K0002 to serve borrower ID K0002.
  2. Note the due date on the books for the borrower.
  3. Set system date to a week or more after the due date.
  4. Observe the Fines amount.


[original: nus-cs2103-AY1920S1/pe-interim#1161]

seeziyang commented 4 years ago

Team's Response

Thanks for testing our app.

It seems like you misunderstood/misinterpreted our feature as this is the correct and intended behaviour.

It is intended behaviour for the fine amount to only be updated when borrowers return their overdue books. That is, the borrower only incurs a fine after he returns an overdue book. This is clearly stated in the UG. The books in your screenshot are not returned yet. There is no need to restart the application for a borrower's outstanding fine amount to be updated as it is automatically updated once a fine is incurred.

Having a rolling fine amount that also track fines for books that are not returned is confusing to the user. The borrower may come to the librarian (before he/she has returned the overdue books) and think that he/she has fines due from previous loans.

In any case, this is the behaviour we intended the system to have, and therefore cannot be classified as a bug.

image.png A example was also given in the instructions for manual testing.

Duplicate status (if any):

Duplicate of #2175