nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Find self has odd implementation. #140

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

image.png

Tested it, will return incidents not created by yourself as long as you have the same name. Is this intentional design?

Hence, incidents cannot be submitted even if you're only finding self-issues. As urgency is crucial here, it does not make sense that the user has to sieve through other people's creations just because they have the same name. Why not by username, which can't be duplicated?

image.png


[original: nus-cs2103-AY1920S1/pe-interim#140]

Yoshi275 commented 4 years ago

Team's Response

Implementation follows the expectations set by the User Guide. image.png

This implementation was originally selected (and acknowledged in the user guide) because of a consideration that there were no unique identifiers for each individual user. Given that operators are supposed to register with their full names, it is highly unlikely that any duplicate names arising in the error will occur as well, especially given that each operator should be limited to one account.

The issue regarding using the find-i self command then failing to be able to submit seems to be a non-issue, as the user clearly cannot submit an incident that is not created by them.

However, the consideration of using unique usernames acknowledges an oversight on our part. We would like to acknowledge it, while reducing the severity of the issue due to the unlikelihood of the system facing a similar situation, nor the repercussions following it.

Duplicate status (if any):

--