search

nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Shopping list is not updated when grocery list is updated #168

Open nus-pe-bot opened 5 years ago

nus-pe-bot commented 5 years ago

Describe the bug Shopping list is not updated when item in shopping list is editted in the grocery list.

To Reproduce Steps to reproduce the behavior:

  1. slist list (Beef should be partially bought there)
  2. glist find Minced Beef
  3. glist edit 1 n/Nasi Lemak

Actual behavior Minced Beef in shopping list still shows partially bought.

Expected behavior Minced Beef in shopping list should not have partially bought tag as your grocery list does not contain any minced beef.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

[original: nus-cs2103-AY1920S1/pe-interim#168]

ManasVegi commented 5 years ago

Team's Response

Bought items of the shopping list have nothing to do with the grocery list.

Grocery list represents items that are in your fridge, while bought items represent shopping items that have been bought but not yet moved to the fridge.

This is why bought items are not immediately to the grocery list, there is a mergebought feature for that purpose.

This distinction is made clear by the existence of the mergebought feature and the description of the mergebought feature in the UG that mentions that the command "adds all items marked as ‘bought’ to the grocery list".

Hence editing bought shopping items when grocery items are edited would not be of value the user and would cause regressions.

Duplicate status (if any):

--