nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

The add accomodation command does not handle duplicate input field tags elegantly #1846

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

For example, when entering the command "add accommodation n/firstName n/secondName a/testaddress" will result in adding a new accomodation with the second name, when instead it should be throwing an error to the user to indicate duplicate input field tags.

image.png

Entering the command as shown above, will result in the page displayed below.

image.png

From the image, you can see that a new accomodation with the name "secondName" is added successfully to the list of accomodations when in fact, it should be raising an issue.

This bug also works for address and phone fields as well.

*Upon additonal testing for other commands, it seems that this bug works for all commands that take in fields similar to add accomodation.


[original: nus-cs2103-AY1920S1/pe-interim#1855]

ernestyyh commented 4 years ago

Team's Response

Thank you for the issue raised.

We have reduced the issue severity to “Low” as this may cause only a minor inconvenience the users. This behaviour of accepting duplicate input fields was inherited from AB3.

As such, the issue raised is considered to be “Rejected” due to the inheritance from AB3.

Duplicate status (if any):

--