nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Adding large budget values results in the budget being added incorrectly #2029

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago
  1. Ran the following command to add the budget: image.png

  2. Budget reflected is different from the specified budget. image.png


[original: nus-cs2103-AY1920S1/pe-interim#2038]

anqichen9856 commented 4 years ago

Team's Response

This is due to Java's rounding of big double values:

Screenshot 2019-11-17 at 13.55.03.png

Downgrading to Severity.Low: The entered budget amount in the screenshot is wildly beyond an expense a normal user would enter. As the budgets and expenses a user sets is completely up to themselves we did not want to put too much restrictions on the maximum limit for the amount a user can use. However, I do not believe that our target user, the general NUS Student, would need to manage such a large budget. Finally, when values become very large, the difference that 1 dollar can make becomes infinitely small. This does not in any way affect the normal function of MooLah.

Duplicate status (if any):

--