nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

When an entry's value has overflown, the application ceases to function #2036

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

Attempting to run a legitimate command (copied from the UG) after an entry with a large value is displayed does not work.

image.png


[original: nus-cs2103-AY1920S1/pe-interim#2045]

briyanii commented 4 years ago

Team's Response

Rejecting this issue due to lack of proper evidence as well as the inability to reproduce this issue.

Firstly, the commands seem to be ones that would fall outside of normal usage and the exact inputs cannot be inferred from the screenshot provided.

In an attempt to reproduce the bug, the following steps were taken:

Firstly regarding ridiculously large expenses, I tried inputting the following.

addexpense d/large expense 1 followed by 3 x 180 zeros c/ food p/ 1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

Will result in the following complaint.

This expense will exceed the budget limit too far

I tried to create a budget which has allowance for such a large expense by inputting the following

addbudget d/large budget 1 followed by 3 x 180 zeros pr/week sd/today p/ 1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

Which results in the following budget being created. Screenshot 2019-11-17 at 17.23.35.png

followed by inputting the previous ridiculous expense again several times.

addexpense d/large expense 1 followed by 3 x 180 zeros c/ food p/ 1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

Screenshot 2019-11-17 at 17.25.04.png

Followed by entering an event in the expense list panel as shown in the report. The result is that the event is successfully added with no bug.

Screenshot 2019-11-17 at 17.27.24.png

I then tried an expense with less zeros by entering the following to try to achieve the same long expense price entry:

addexpense d/large expense 1 followed by alot of zeros c/ food p/ 100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

And this was added sucessfully with no problems. Screenshot 2019-11-17 at 17.31.26.png

and similarly adding an event resulted in no problems.

Screenshot 2019-11-17 at 17.31.26.png

I am unable to reproduce this bug and encounter no problems while attempting to add ridiculously large expenses. Even with an expense which appears to be much larger than the expense described in the bug report (notice that the scroll bar track is much longer compared to the actual bar itself, compared to the provided screen shot in the report)

Additionally I am decreasing the severity of this bug from High to Low:

Finally, there is no evidence that the application has actually ceased to function. The screen shot provided is just a screenshot of the command inside the command box along with a claim that it does not work. There is no stack trace showing the exceptions thrown which would normaly be the case given that the application has ceased to function while still displaying the UI, nor any other evidence of the application not responding (e.g. screenshot of the task manager, or the other OS' equivalent). While I am not questioning the tester's integrity, I also feel that it is not warranted for us to be penalised for a High severity bug report which has no proper evidence of the fatal error and which we have been unable to reproduce. Hence, I am rejecting this issue.

Duplicate status (if any):

--