nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Add Command Bug in Cheatsheet #2081

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

The user-guide explicitly lists the parameter "/tag" as optional, but the application enforces the PRESENCE of an argument for it. This is significant deviation from the user-guide since a seemingly optional parameter has been made compulsory.

However, the entire point of enforcing a tag for cheatsheets is defeated because users can use the edit command to remove tags. This can leave a cheat-sheet with no associated tags, which makes enforcing the "/tag" parameter redundant.

Below is an image of the user guide, which clearly indicates that tag/ is optional (The user guide states that parameters inside square brackets (Eg. "[parameter]") are optional)

image.png

Below is an attempt to enter an add command without a tag

image.png

The following image shows the error message that is unexpected since /tag was thought to be optional

image.png

The next image shows an added cheatsheet

image.png

The next image shows the same cheat sheet edited to have its tag removed.

image.png


[original: nus-cs2103-AY1920S1/pe-interim#2090]

jaesimin commented 4 years ago

Team's Response

This issue contains 2 problems which 1 is accepted and another is rejected: