search

nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Malformed inputs with stary quotation marks not well handled #2221

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

It seems that malformed inputs where there are stray quotation marks are not well handled.

Steps to reproduce: 1) Use add_task "buy --due "20/11/2019 20:00" 2) Program accepts command with malformed behavior.

image.png

[original: nus-cs2103-AY1920S1/pe-interim#2230]

Kyzure commented 4 years ago

Team's Response

Hello, thank you for your bug report.

There are two explanations for this:

  1. The user may want to use quotation mark in their event description, hence we allow quotation marks inside our quotation marks.

  2. In the command add_task "buy --due "20/11/2019 20:00", there is no spacing " and 20, which causes "buy --due "20/11/2019 20:00" to seem as the task description. If add_task "buy --due " 20/11/2019 20:00" was used instead, the command would have been parsed into "buy --due ", 20/11/2019, 20:00". "buy --due " would be the task description, while the other two arguments would be silently ignored:

image.png

Hence, we believe that there is no issue, although we should improve our documentation to explain this.

Sorry for any inconvenience caused, and we hope you continue to enjoy using Horo.

Duplicate status (if any):

--