nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

issue with w/ parameter for search command #2362

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

the w/ parameter of search command is supposed to narrow down the search to movies that we have already watched or not watched. but if (o/no) offline is not specified, then w/no & w/yes gives the same results. no errors are thrown. its the exact same results as shown below upon typing the command. (Btw there are no movies in the watchlist or watched list)

"search g/comedy w/no"

image.png

"search g/comedy w/yes"

image.png


[original: nus-cs2103-AY1920S1/pe-interim#2371]

michelleykw commented 4 years ago

Team's Response

It might not have been clear enough in the user guide that in order for users to search from within the watchlist or watched-list, they have to specify o/no followed by either w/no or w/yes. Otherwise, the w/ field would have been useless and EzWatchlist would not be filtering the shows. Thus, I would think that this is more of a documentation bug than a functionality bug as it was intended to not be able to search from watched-list if o/no is not specified.

This is because if the user were to be searching from online, the shows from the online database would not have been in the user's watchlist or watched-list, thus, it is not possible for them to simply search w/yes without o/no. This flaw is most unlikely to affect users for normal operation of the product if they were to be following the user guide closely. Perhaps, what could have been done better was that once the user were to indicate w/yes, EzWatchlist could have just simply know that o/ also to be set to o/no. Also, perhaps, in the case without o/no specified, an error could have been thrown to users to prompt them to do so.

Also, as mentioned in the user guide, in order to search from the watchlist or watched-list, user has to specify o/no as well. Hence, we believe that with that tip provided in the user guide, it would have been clear enough for users that, when searching from either watchlist or watched-list, they would have to input o/no. Hence, we would have to reject this as a documentation bug as well, as we believe that it has been clearly stated in the user guide.

Screenshot 2019-11-17 at 7.11.27 PM.png

Thank you.

Duplicate status (if any):

--