nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Self method calls not returning in sequence diagram #2391

Open nus-pe-bot opened 5 years ago

nus-pe-bot commented 5 years ago

Screenshot 2019-11-15 at 5.12.38 PM.png

This image might have been reported before but due to lack of time in exam conditions please understand.

The method calls to itself should return with dotted lines. Similarly for numerous sequence diagrams throughout the developer guide. Especially those with the same theme.


[original: nus-cs2103-AY1920S1/pe-interim#2400]

ning-sy210 commented 5 years ago

Team's Response

Thank you for pointing this out, we will make the necessary changes to reflect the correct sequence diagrams 🙂

However, return arrows need not be included as long as they don't omit important details from the sequence diagrams. Please refer to the screenshot below which is taken from the module website. Although the example shown is not for self method calls, we assume that this rule also extends to self method calls, since it is not mentioned anywhere otherwise.

image.png

Duplicate status (if any):

--

limhawjia commented 5 years ago

Team's Response

Thanks for the feedback. We will be updating all of these diagrams to use dotted return arrows. We apologize for any confusion that it may have caused.

Duplicate status (if any):

--