nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Removing available slots for interviewer not allowed #604

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

Screenshot 2019-11-15 at 12.41.32 PM.png

It seems that empty available slot entry for an interviewer is allowed. This is ok given that in real life some interviewers are indeed not free. So as an interviewer who just get other commitment that overlaps with the available slot, I would want to remove my available slot so that no interview can be scheduled during that slot (in fact I am not available).

Expected: By using edit command, edit Person C r/interviewer s/[Empty] allows a user to remove the interview slot

What happened: This is disallowed. In this case, if the user is not free anymore, he/she would either need to delete his/her entry or have no choice but to accept the interview that might be scheduled then (since he/she is technically "free" in the app). This is user unfriendly as the user might want to keep his/her entry for convenience sake while emptying up the available slots field (since it is allowed to be empty).


[original: nus-cs2103-AY1920S1/pe-interim#606]

KendrickAng commented 4 years ago

Team's Response

Dear Tester,

As per the user guide for the edit interviewer command: "If a slot prefix s/ is supplied, at least one valid, non-empty slot must be provided.". We made the decision to disallow editing an interviewer to have no slots due to the clutter it would cause the app. An interviewer with no available time slots should not be in Scheduler.

We also argue that Scheduler is meant to generate interview timeslots quickly based on information already available - hence it would be rare that the user, a Secretary of an NUS CCA (as stated in our user guide), would need to refer back to the app constantly. In the occasional times he/she meets the situation you mentioned, executing the delete interviewer command instead of the edit interviewer command would be a negligible inconvenience. We therefore reject this bug.

Thank you.

Duplicate status (if any):

--