nus-cs2103-AY1920S2 / pe-dev-response

0 stars 0 forks source link

Profit command (Error message does not match the actual error specified in DG) #1082

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

Test case: profit sd/2020-09-01 10:00 ed/2020-01-12 10:01 Expected: Profit cannot be calculated if start date is after end date. Error details shown in the status message.

Instead, error message is should not be in the future. The message is not specific to the error stated above. See screenshot for more details.

Steps to reproduce: 1) clear the customer's list 2) addc n/John p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney 3) addp d/iphone cp/400 pr/1000 q/10 s/100 4) Customer and products each have only 1 data. 5) addt c/1 p/1 q/1 dt/2020-04-11 11:44 m/30 d/under discount 6) profit sd/2020-09-01 10:00 ed/2020-01-12 10:01 7) each transaction, customer and product list should have only one data item. u will see the error message

Screenshot 2020-04-17 at 3.03.37 PM.png


[original: nus-cs2103-AY1920S2/pe-interim#1049]

syt23 commented 4 years ago

Team's Response

We should have stated that the dates are not in the future in the preconditions. However this is not a high severity bug. High severity means 'A flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users'.

Obviously, this does not make the product unusable for most users, since the error message displayed is the correct message that will help resolve the problem. In other words, the user just needs to follow the instructions by changing the date to a date in the present/ past, then the command will be correct.

As such, we classify this as low, which means 'A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.' since it does not affect normal operations.

Moreover it is not a functionality bug, instead it is a documentation bug as the intended message is that the date has to be in the present/ past.

Duplicate status (if any):

--