nus-cs2103-AY1920S2 / pe-dev-response

0 stars 0 forks source link

Savings calculation can be improved. #2412

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

I believe it is the case that coupons can be spent on items that are worth less than the coupon's value (assuming there's no minimum amount spent required). And in that case you would not receive any refund for the excess value of the coupon. Therefore, when I entered $5 for the "used" command, the app should not report that, for a $10 coupon, $10 has been saved. It should be $5 instead. Screenshot from 2020-04-17 14-22-46.png


[original: nus-cs2103-AY1920S2/pe-interim#2392]

alcen commented 4 years ago

Team's Response

This is intended behaviour as stating the original amount spent is only necessary for coupons that are represented by a percentage amount. It is clearly stated in the User Guide (section 5.5).

image.png

In the event that you would want to save less than what is reflected on the original coupon, the team suggests you to edit the coupon savings first before entering the used command

Severity has been downgraded as this flaw is more related to the cosmetic representation of savings in the application, which may not reflect that the amount can only be set with the add and edit commands. It is quite ridiculous to consider this a "severity.High" issue as the main used command functionality still works as expected without any major problems

Duplicate status (if any):

--