search

nus-cs2103-AY1920S2 / pe-dev-response

0 stars 0 forks source link

weekly lessons got added even though error was thrown. #2527

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

added lesson d\st2334 tut v\home t\monday 10:00 12:00 but was shown already have an event in that time frame. moved on to changed the timing from 15:00 - 16:00 which was ok. however, i moved on to view week i\1 which i realised the 10:00-12:00 lesson got added even though error was shown, so i expected the lesson was not added in.

Screenshot 2020-04-17 at 2.40.27 PM.png

Screenshot 2020-04-17 at 2.42.46 PM.png

[original: nus-cs2103-AY1920S2/pe-interim#2517]

xCelestialPhoenix commented 4 years ago

Team's Response

Changed severity from severity.High to severity.Medium as product is still usable.

Rejecting this as a bug as it was expected behaviour. For the lesson command, lessons will be added to all weeks which have the specified timeslot free. e.g. if every week from 1 - 13 has the timeslot free except for week 8, then the lesson will be added to weeks 1-7 and 9-13. We acknowledge that the error message could have been clearer, e.g. "lessons added to all weeks, except week 8, which already has an event in that timeframe", and the assignee is willing to take responsibility for that.

Duplicate status (if any):

--