search

nus-cs2103-AY1920S2 / pe-dev-response

0 stars 0 forks source link

Not detect invalid name input #2608

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

add interviewee with only punctuation is not detected.

image.png

[original: nus-cs2103-AY1920S2/pe-interim#2608]

CornCobs commented 4 years ago

Team's Response

Due to the nature of our app (a hiring app), we are unable to control the names of the interviewees our users will use the app to interview. It is impossible to validate every single possible name in all languages in the world. (Some names have numbers (Joshua the 2nd), some have punctuation (Tom O'brien), some only contain non-ascii characters, like CJK (Chinese, Japanese or Korean) names). Thus our app seems to be as permissive as possible for names. The only names that our app rejects are those that cause validity issues in the app.

  1. Blanks. An empty name is impossible to identify. Furthermore this is reasonable as we can expect every interviewee to at least have a name.
  2. Entirely numerical names. A name that is an integer (eg. 12345) will clash with our HireLah's use of unique integer ids as an alternative to identify interviewees. This is also reasonable as it is very unlikely an interviewee has a number for a name.

For these reasons, we have decided to accept even a name containing entirely punctuation (There is no single character class that is present in ALL names). We deem this a feature not a bug.

Duplicate status (if any):

--