search

nus-cs2103-AY1920S2 / pe-dev-response

0 stars 0 forks source link

Comments for sequence diagram inside logic for deleteroom #299

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

No details provided. image.png

  1. The parse command("deleteroom /rn 1") is way too small

  2. The command should be "deleteroom rn/ 1" I believe

  3. Inconsistent with the other sequence diagrams

  4. Returned value doesnt start from the end of the activation bar (eg CommandResult)

  5. The arrows would crossover to inside the box instead of just touching:

image.png

[original: nus-cs2103-AY1920S2/pe-interim#294]

sancharib-git commented 4 years ago

Team's Response

Severity changed to low as issues are all typos and errors due to limitations of UML drawing application. Does not affect normal operation of the app.

No idea what tester means by 'inconsistent with other sequence diagrams" - Unclear.

Duplicate status (if any):

--