search

nus-cs2103-AY1920S2 / pe-dev-response

0 stars 0 forks source link

Activity diagram for schedule #746

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Guard clauses should be outside the diamond

Screenshot 2020-04-17 at 3.27.01 PM.png

[original: nus-cs2103-AY1920S2/pe-interim#721]

alloystory commented 4 years ago

Team's Response

The guard clauses are already outside the diamond, just that there is an additional conditional statement inside the diamond. However, this is accepted UML notation for conditionals, as per the PlantUML documentation here https://plantuml.com/activity-diagram-beta. However, we do acknowledge that the textbook has a slightly different notation.

In addition, this bug is purely cosmetic and will not confuse developers who are reading this diagram. Therefore, we reassigned this issue a severity of very low.

Duplicate status (if any):

--