search

nus-cs2103-AY2021S1 / forum

20 stars 2 forks source link

tp dashboard does not detect my assertions #363

Closed zhxchd closed 4 years ago

zhxchd commented 4 years ago

I remember that last week when I checked the tp dashboard the "assertions" tag has been marked as done. While now as I check the dashboard, it says overdue. I did use a few assertions in last week's commits which have been merged into master last week. May I check why this happened? My GitHub name is zhXchD, student number is A0194512H and my Git author name is Zhu Xiaochen <zhuxiaochen1005@gmail.com>.

zhxchd commented 4 years ago

You may want to have a look at this commit, which was committed by me 7 days ago, at here. I think I included assertions in this commit.

damithc commented 4 years ago

We go by what's shown in the cod dashboard. Check if any asserts are included in the code that is shown as your code in the code dashboard.

zhxchd commented 4 years ago

We go by what's shown in the cod dashboard. Check if any asserts are included in the code that is shown as your code in the code dashboard.

I just checked the reposense code dashboard. I found the commit (named Add assertions, on 2020-10-20, can check at here). This is the commit I mentioned in the previous comment. The screenshot is shown below

Screen Shot 2020-10-27 at 10 29 43

Inside this commit, you can find there are assert() used in my code.

damithc commented 4 years ago

I just checked the reposense code dashboard. I found the commit (named Add assertions, on 2020-10-20, can check at here). This is the commit I mentioned in the previous comment. The screenshot is shown below

It doesn't matter if the commit is detected as past commits can be overwritten by later commits. What matters is the code view which shows the final state of the code. Check if those lines are shown under your name in the code view (click on the </> icon to see the code view)

zhxchd commented 4 years ago

It doesn't matter if the commit is detected as past commits can be overwritten by later commits. What matters is the code view which shows the final state of the code. Check if those lines are shown under your name in the code view (click on the </> icon to see the code view)

I checked the code and it shows something like this.

Screen Shot 2020-10-27 at 10 40 58

Only the assert() lines are not highlighted as green, does this mean that the assertions are not detected as my code? I think it is because that someone else in the group make changes after I wrote the code because last week this item was detected as done but not this week. If I use the author tags to indicate these lines are actually my code, will the system detect this and mark this item as done (it is now marked as overdue)? Thanks prof!

damithc commented 4 years ago

Only the assert() lines are not highlighted as green, does this mean that the assertions are not detected as my code? I think it is because that someone else in the group make changes after I wrote the code because last week this item was detected as done but not this week. If I use the author tags to indicate these lines are actually my code, will the system detect this and mark this item as done (it is now marked as overdue)? Thanks prof!

Yes, that should work @zhXchD The item will turn back to green if you do that.