search

nus-cs2103-AY2021S1 / forum

20 stars 2 forks source link

Catcher Images 404 due to branch naming #421

Closed zhiayang closed 3 years ago

zhiayang commented 3 years ago

Maybe this fits better on the catcher repo, but it's probably more visible here. Looks like the Catcher workflow assumes that the user's Github setting for "default branch name" is main, instead of master. Furthermore, it looks like the process for "transferring" links from the student's PE repo to the central issue repo is simply done via a basename replacement, without considering the actual resource path.

For example, the path to a screenshot in my PE repo might be raw.githubusercontent.com/zhiayang/pe/master/files/image.png; the image is copied to the central repo, and the username portion is replaced. However, the central repo's branch name is main, leading to a 404 for all screenshots that I posted, because the central repo does not have a master branch.

This is a pretty serious bug, and I'm not sure how many people it affects. @damithc

damithc commented 3 years ago

Thanks for letting us know @zhiayang Should be fine now. I've created both main and master branches in the central repo so that either should work. I've checked one of you issues to confirm that the image is visible.

zhiayang commented 3 years ago

Yep, has been fixed! Thanks prof for the fast response.