nus-cs2103-AY2021S1 / forum

20 stars 2 forks source link

Clarification on PE-phase 2 responses #424

Closed chewypiano closed 3 years ago

chewypiano commented 3 years ago

Dear professors, tutors and peers,

I would like to inquire as to whether we can change the severity of the bug without explanation if we are going to reject it, or do we still need to justify it (justify the changing of severity) in this case?

Similarly, since marking an issue as a duplicate requires you to tag it to an issue of the same severity, can we just change the severity without explanation?

Regards and thanks, Kamil Gimik

damithc commented 3 years ago

The explanation is optional. It's just a way for to explain your reasoning to the tester (thus, reducing the chance of the tester disputing your change/rejection) and to the teaching team (in case the tester disputes your change and the teaching team has to make the final decision). So, omit at your own risk.

chewypiano commented 3 years ago

Thank you for the quick response prof, what I meant is that since I give reasoning for complete rejection of the issue, is it actually a risk to omit reasoning for the lesser charge of reducing its severity level (on issues that I am already rejecting)?

And for my second question, CATCHER only allows to duplicate the issue if it has the same severity as the parent issue (the issue that you are saying it duplicates). Thus, changing the severity is more of a necessity in this instance. Do we also need to justify this change?

Regards and thanks, Kamil Gimik

damithc commented 3 years ago

Thank you for the quick response prof, what I meant is that since I give reasoning for complete rejection of the issue, is it actually a risk to omit reasoning for the lesser charge of reducing its severity level?

What if your rejection is disputed by the tester and the teaching team decides in favor of the tester? Then, the teaching team has to make a decision on whether the severity change can be allowed too.

And for my second question, CATCHER only allows to duplicate the issue if it has the same severity as the parent issue (the issue that you are saying it duplicates). Thus, changing the severity is more of a necessity in this instance. Do we also need to justify this change?

Just because one tester gave it a low rating doesn't mean you can lower a higher rating given by another tester to the same bug. Either you should choose the one with the higher rating as the 'original', or justify the lowering of the severity in the 'duplicate'. Again, remember that the duplicate status can be revoked by the teaching team later. In that case, each of those bugs will have to justify their own severity. If there is no justification from you, we might have to go with the original severity given by the tester.

chewypiano commented 3 years ago

Noted with thanks sir. Again, thank you for the prompt responses.

Regards, Kamil Gimik