nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Featuer flaw: Same name should not mean same supplier. #1131

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

Commad: add ct/s n/hi p/0123 e/asd@com add ct/s n/hi p/01234 e/asda@com

Expected: Input to be accepted, since 2 suppliers can have the same name, but different email/number.

Actual: Error message thrown indicating supplier is in CLI-nic already. I believe this is a feature flaw as 2 suppliers can have the same name. Maybe shoud add in mobile number/email for identity checks.

image.png


[original: nus-cs2103-AY2021S1/pe-interim#1034]

tohyuting commented 3 years ago

Team's Response

The probability of two suppliers or warehouses with the same name will be very low. If there are indeed two suppliers or warehouses with the same name, the users should use other means (e.g. using parentheses in the supplier or warehouse name when adding the supplier or warehouse). On the other hand, it should be allowed for two suppliers or warehouses with different names yet have the same phone number, email or address as the same person could be in charge/managing several warehouses and suppliers).

Our team have discussed this issue during the development of CLI-nic and here is the link to the issue on Github of our discussion: #149

Duplicate status (if any):

--