search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Countdown Class Diagram #2926

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

CountdownEvenListPanel is stored in CountdownTabWindow and when CountdownTabWindow is destroyed, CountdownEventListPanel is destroyed as well (composition). Since CountdownEventCard is stored in CountdownEventListPanel, shouldn't it be a composition as well?

image.png

For example the planner class diagram below shows the PlannerDayCard as a having a composition relation with PlannerCalendarPanel:

image.png

[original: nus-cs2103-AY2021S1/pe-interim#2699]

ruilingk commented 3 years ago

Team's Response

Adding the composition symbol is an additional information that merely adds value to the diagram, and it is still a valid class diagram without the composition symbol.

image.png

According to this section of the module website, ommiting optional notation is not a bug.

Duplicate status (if any):

--