search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Does not make sense to allow mass assignment/clearing of leave to loop across week boundary #31

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

As stated in the UG: "The day/time range will loop properly between Sunday and Monday. Hence mass-take-leave w/2 d/SUN t/AM d/MON t/AM will work as intended - leave taken on Sunday morning to Monday morning."

Since the McScheduler currently does not support logic to assign different shifts/leave across different weeks, assigning leave as shown above would most likely mean that the user will be assigning leave for worker 2 on Monday morning AND the whole of sunday for that week, which is not in a continuous block.

Similarly, if the shift manager wants to clear a worker's' leave for the day but accidentally types in the t/pm parameter before the t/am parameter, this will result in the worker's leave for the entire week being cleared.

Consider removing this feature until McScheduler feature support shifts in multiple weeks.

[original: nus-cs2103-AY2021S1/pe-interim#29]

wakululuu commented 3 years ago

Team's Response

Since the McScheduler currently does not support logic to assign different shifts/leave across different weeks, assigning leave as shown above would most likely mean that the user will be assigning leave for worker 2 on Monday morning AND the whole of sunday for that week, which is not in a continuous block.

Shift managers may not standardise how they organise their shifts across restaurants. For instance, they may begin their scheduling from Sunday. In this case, the example you have given would be a continuous block. Managers may also beginning scheduling for the following week (for instance, after Thursday, managers may use the Monday shifts to refer to the following Monday). Hence, it is best to leave this option open for users' convenience.

Similarly, if the shift manager wants to clear a worker’s’ leave for the day but accidentally types in the t/pm parameter before the t/am parameter, this will result in the worker’s leave for the entire week being cleared.

This is the intended behaviour of the command and it is possible that the user would like to clear the entire week of leaves of a worker. Hence, this functionality is also kept open for the user to utilise.

Due to the reasons above, the severity has been dropped to low as the normal operations of the product will not be affected.

Duplicate status (if any):

--