search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Undo/Redo command does not work with find command #3392

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

The user guide states that the undo/redo command undoes/redoes the previous command. However, the undo/redo command does not undo/redo the find command

image.png

Steps to reproduce:

  1. Starting from a fresh copy of the app, type find-i n/MILK and press enter
  2. type undo
  3. App states that there are no commands to undo

image.png

The user guide does not mention that the undo/redo features only work with specific commands. Even if that is the case, the error message provided is inappropriate. It would be better to say that the undo/redo does not work on X command instead of saying that there are no more commands to undo.

[original: nus-cs2103-AY2021S1/pe-interim#3121]

Wincenttjoi commented 3 years ago

Team's Response

image.png

This is part of the intended functionality of our application. The find command does not change the state of the inventory book or the delivery book and thus does not warrant an undo command. We mentioned this in our Developer guide, but could have made it clearer in our User guide. Hence, we will change this as a documentation bug.

Duplicate status (if any):

--