nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

`c-tag-find` does not return archived employees #3412

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

Added both John Doe (active) and George Doe (archived). Both tagged as special. image.png image.png

Using c-tag-find: before image.png after image.png

As you can see, George Doe is not returned. This command should be updated to allow for both.

Perhaps this command has the same limitation as c-find command where it only returns active employees as mentioned in the UG. If this is the case, the UG should be updated in a similar fashion to c-find.


[original: nus-cs2103-AY2021S1/pe-interim#3143]

ureshiiYing commented 3 years ago

Team's Response

Thank you for the bug report.

However, we have changed the bug type to documentation bug, instead of feature flaw. Feature flaw means that the feature does not suit the problem given. The feature works as expected. In normal daily operations, when the manager (user) wants to get a filtered list of employees, he should only be searching through the active (unarchived) employees. The archived employees should be ignored as they are no longer working in the shop. Thus, the expected behaviour of this feature is reasonable.

It is actually a documentation bug, as clearer instructions should be given. i.e stating that it will only find the active employees instead of finding all employees.

image.png

Duplicate status (if any):

--