nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Questionable valid phone numbers #3424

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

I think this feature is flawed because there are variations to a mobile number, numbers starting with 6, or 1800-245-6524, or what if 999 is my emergency number?

image.png


[original: nus-cs2103-AY2021S1/pe-interim#3154]

ureshiiYing commented 3 years ago

Team's Response

Thank you for the bug report. This is marked as a duplicate bug report as #1547, due to the similar nature of suggestions about phone number restrictions.

For numbers starting with 6, those are typically landline phone numbers, and are not for Singaporean personal mobile phone numbers. Including numbers starting with 6 could be an improvement. However, we believe that the original feature is reasonably useful and meets its purpose, as the manager should expect to be able to contact his employee directly through his personal phone number; there is also a further need to contact his employee’s emergency contacts through their personal phone number directly, since that is the purpose of an emergency contact.

For the latter two, it is unlikely that an employee would provide a helpline (1800-xxx...) or a public service number (eg. 999 or 995) as his emergency contact number, since an emergency contact is usually someone who is close to the employee.

Duplicate status (if any):

Duplicate of #1547