nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Editing persons to the same email #3598

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

I was able to edit person 1 to have the same email as person 2. This should not be allowed and can create a lot of confusion.

image.png


[original: nus-cs2103-AY2021S1/pe-interim#3330]

hopinxian commented 3 years ago

Team's Response

Firstly, this is inherited behaviour from Addressbook. Addressbook allows persons to share the same email if they do not have the same name.

In addition, it is clearly described in the features section of the user guide that VirusTracker flags duplicates which occurs if both persons have the same name and same email. This is not the case in the example shown, since both persons have different names.

A case can easily be made to justify why people should be allowed to share the same email. Young dependents of an adult whom do not have an email (e.g. young children and babies), should be allowed to share emails from their parents.

Duplicate status (if any):

--