nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

The mechanism for checking same person in contact management seems to be weird #3648

Open nus-se-bot opened 4 years ago

nus-se-bot commented 4 years ago

image.png

The user guide shows that both contacts are accepted, perhaps because they have a different email. But in my opinion the same name and phone number (in this case even same address) should already warn users of adding potential duplicate contacts. Maybe it should prompt the user to edit new email rather than accepting it.


[original: nus-cs2103-AY2021S1/pe-interim#3383]

maguireong commented 4 years ago

Team's Response

Screen Shot 2020-11-16 at 4.41.48 PM.png

Thank you for the suggestion, but this was a deliberate design choice to make it less restrictive. It makes sense to have clients from the same family that are contactable by the same home number, for example. It’s also possible that clients prefer to use office phones, which can be shared.

Therefore, we used email address as part of the identifier because it’s easier to acquire a new email address if it happens that there’s another client with the same name, compared to a new phone number (which would entail additional financial costs to the client).

Regarding whether it is intended ("perhaps because they have a different email."): yes, it is intended as specified in our UG.

Screen Shot 2020-11-15 at 3.14.17 AM.png

Screen Shot 2020-11-15 at 3.13.45 AM.png

Duplicate status (if any):

--