search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

The session overlapping checking doesn't seem to work on boundary value #3706

Open nus-se-bot opened 4 years ago

nus-se-bot commented 4 years ago

Steps to reporuduce the bug:

  1. Start from clean state. clear all existing data
  2. Run sadd g/New Gym ex/Endurance at/06/11/2020 0900 t/65
  3. Run sadd g/New Gym ex/Endurance at/06/11/2020 1005 t/65

Following the above steps will not result in any error, however, there should actually be a bug report due to overlapping schdules.

Give 9am as starting time, a duration of 65 minutes will result in the next available schudle being 1006 rather than 1005.

[original: nus-cs2103-AY2021S1/pe-interim#3447]

kelvinvin commented 4 years ago

Team's Response

This is deliberate design choice based on real world usage.

A class from 1pm - 2pm and then a class from 2pm - 3pm is perfectly valid. Real life schedules treat the boundary values of start and end time as exclusive. You wouldn't see someone listing their class as starting at 2.01pm.

We also specify this in UG. Two sessions are overlapping if another session starts before the current session ends. (since 10.05 is not before 10.05, hence it is considered as a non-overlapping session)

image.png

We also change the bug severity to Low because we feel it is unlikely to affect normal operations of the product. User can continue to use the product, and we strongly believe our current constraint is more natural for the users than what you have suggested, as explained in our argument above.

Duplicate status (if any):

--